Skip to content

Update translations/coordinating.rst #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 18, 2025
Merged

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jun 23, 2025

This page is aimed at coordinators, so I assume some git/gh knowledge etc.

Some things that need to be discussed:

closes #1586


📚 Documentation preview 📚: https://cpython-devguide--1587.org.readthedocs.build/

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jun 24, 2025

While this has to wait for a pending issue, other discussion should continue. These are comments I left in the file in the format, XXX thought.

Requesting @rffontenelle and @m-aciek

@StanFromIreland StanFromIreland marked this pull request as ready for review June 24, 2025 19:06
Copy link
Contributor

@rffontenelle rffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. Please find some notes below

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

@StanFromIreland
Copy link
Member Author

Thanks for the review.

I should have my editor highlight it in red:-)

@StanFromIreland StanFromIreland requested a review from hugovk June 27, 2025 13:46
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Aug 5, 2025

Since this pr is taking a while (due to it's size already), we can leave the todos that need discussion to follow ups. Would it be possible to get a review @willingc?

Co-authored-by: Hugo van Kemenade <[email protected]>
@StanFromIreland
Copy link
Member Author

Thanks for making them suggestions!

@willingc
Copy link
Collaborator

willingc commented Aug 5, 2025

Thanks @hugovk for reviewing. I tried to review this morning and hit 500 errors from GitHub. Will review now.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StanFromIreland for making these changes.

@StanFromIreland
Copy link
Member Author

Anything left to do to get this merged?

@encukou encukou merged commit b0aefe9 into python:main Aug 18, 2025
4 checks passed
@StanFromIreland StanFromIreland deleted the coordinating branch August 18, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants